Skip to content

[Test] Remove ismodularlibrary true in tspconfig #38893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[Test] Remove ismodularlibrary true in tspconfig #38893

wants to merge 1 commit into from

Conversation

@v-jiaodi
Copy link
Member

@v-jiaodi v-jiaodi commented Nov 20, 2025

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

Click here to open a PR for only SDK configuration.

@github-actions
Copy link

github-actions bot commented Nov 20, 2025 •
edited
Loading

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR targets either the main branch of the public specs repo or the RPSaaSMaster branch of the private specs repo. These branches are not intended for iterative development. Therefore, you must acknowledge you understand that after this PR is merged, the APIs are considered shipped to Azure customers. Any further attempts at in-place modifications to the APIs will be subject to Azure's versioning and breaking change policies. Additionally, for control plane APIs, you must acknowledge that you are following all the best practices documented by ARM at aka.ms/armapibestpractices. If you do intend to release the APIs to your customers by merging this PR, add the PublishToCustomers label to your PR in acknowledgement of the above. Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
  • ❌ The required check named TypeSpec Validation has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide


Comment generated by summarize-checks workflow run.

@github-actions
Copy link

github-actions bot commented Nov 20, 2025 •
edited
Loading

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
Go sdk/resourcemanager/cdn/armcdn
Go sdk/resourcemanager/edgeactions/armedgeactions
Go sdk/resourcemanager/databoxedge/armdataboxedge
Go sdk/resourcemanager/edgeorder/armedgeorder
Go sdk/resourcemanager/eventhub/armeventhub
Go sdk/resourcemanager/fileshares/armfileshares
Go sdk/resourcemanager/guestconfiguration/armguestconfiguration
Go sdk/resourcemanager/maintenance/armmaintenance
Go sdk/resourcemanager/notificationhubs/armnotificationhubs
Go sdk/resourcemanager/sqlvirtualmachine/armsqlvirtualmachine
Go sdk/resourcemanager/trafficmanager/armtrafficmanager
Go sdk/widget-analytics/azmanager
Go sdk/resourcemanager/billingbenefits/armbillingbenefits
Go sdk/resourcemanager/confidentialledger/armconfidentialledger
Go sdk/contosowidgetmanager/azmanager
Go sdk/resourcemanager/dashboard/armdashboard
Go sdk/resourcemanager/datadog/armdatadog
Go sdk/resourcemanager/devcenter/armdevcenter
Go sdk/resourcemanager/dynatrace/armdynatrace
Go sdk/messaging/eventgrid/aznamespaces
Go sdk/resourcemanager/healthbot/armhealthbot
Go sdk/resourcemanager/hybridkubernetes/armhybridkubernetes
Go sdk/resourcemanager/managednetworkfabric/armmanagednetworkfabric
Go sdk/resourcemanager/reviews/armreviews
Go sdk/monitor/ingestion/azlogs
Go sdk/monitor/query/azlogs
Go sdk/monitor/query/azmetrics
Go sdk/resourcemanager/newrelic/armnewrelicobservability
Go sdk/resourcemanager/nginx/armnginx
Go sdk/resourcemanager/relationships/armrelationships
Java com.azure:azure-security-attestation
Java com.azure.resourcemanager:azure-resourcemanager-cdn
Java com.azure.resourcemanager:azure-resourcemanager-edgeactions
Java com.azure.resourcemanager:azure-resourcemanager-databoxedge
Java com.azure.resourcemanager:azure-resourcemanager-edgeorder
Java com.azure.resourcemanager:azure-resourcemanager-eventhub
Java com.azure.resourcemanager:azure-resourcemanager-fileshares
Java com.azure.resourcemanager:azure-resourcemanager-guestconfiguration
Java com.azure.resourcemanager:azure-resourcemanager-selfhelp
Java com.azure.resourcemanager:azure-resourcemanager-maintenance
Java com.azure.resourcemanager:azure-resourcemanager-notificationhubs
Java com.azure.resourcemanager:azure-resourcemanager-resourceconnector
Java com.azure.resourcemanager:azure-resourcemanager-sqlvirtualmachine
Java com.azure.resourcemanager:azure-resourcemanager-trafficmanager
Java com.azure:azure-messaging-webpubsub
Java com.azure:azure-widget-analytics
Java com.azure:azure-ai-projects
Java com.azure.resourcemanager:azure-resourcemanager-billingbenefits
Java com.azure.resourcemanager:azure-resourcemanager-confidentialledger
Java com.azure:azure-contoso-widgetmanager
Java com.azure.resourcemanager:azure-resourcemanager-dashboard
Java com.azure.resourcemanager:azure-resourcemanager-datadog
Java com.azure.resourcemanager:azure-resourcemanager-devcenter
Java com.azure.resourcemanager:azure-resourcemanager-dynatrace
Java com.azure.resourcemanager:azure-resourcemanager-healthbot
Java com.azure.resourcemanager:azure-resourcemanager-hybridkubernetes
Java com.azure:azure-ai-chatprotocol
Java com.azure.resourcemanager:azure-resourcemanager-managednetworkfabric
Java com.azure.resourcemanager:azure-resourcemanager-marketplace
Java com.azure.resourcemanager:azure-resourcemanager-newrelicobservability
Java com.azure.resourcemanager:azure-resourcemanager-nginx
Java com.azure.resourcemanager:azure-resourcemanager-relationships
Java com.azure.resourcemanager:azure-resourcemanager-storageactions
Python azure-security-attestation
Python azure-mgmt-edgeactions
Python azure-mgmt-databoxedge
Python azure-mgmt-edgeorder
Python azure-mgmt-eventhub
Python azure-mgmt-fileshares
Python azure-mgmt-guestconfig
Python azure-mgmt-selfhelp
Python azure-mgmt-maintenance
Python azure-mgmt-notificationhubs
Python azure-mgmt-resourceconnector
Python azure-mgmt-sqlvirtualmachine
Python azure-mgmt-trafficmanager
Python azure-messaging-webpubsubservice
Python azure-widget-analytics
Python azure-ai-agents
Python azure-ai-projects
Python azure-mgmt-billingbenefits
Python azure-mgmt-cloudhealth
Python azure-mgmt-confidentialledger
Python azure-contoso-widgetmanager
Python azure-mgmt-dashboard
Python azure-mgmt-datadog
Python azure-mgmt-devcenter
Python azure-mgmt-dynatrace
Python azure-eventgrid
Python azure-mgmt-healthbot
Python azure-mgmt-hybridkubernetes
Python azure-keyvault-administration
Python azure-keyvault-certificates
Python azure-keyvault-keys
Python azure-keyvault-secrets
Python azure-ai-chatprotocol
Python azure-mgmt-managednetworkfabric
Python azure-mgmt-reviews
Python azure-mgmt-monitoring
Python azure-monitor-query
Python azure-monitor-querymetrics
Python azure-mgmt-newrelicobservability
Python azure-mgmt-nginx
Python azure-mgmt-planetarycomputer
Python azure-mgmt-relationships
Python azure-mgmt-storageactions
Python azure-mgmt-storagemover

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikeharder mikeharder Awaiting requested review from mikeharder mikeharder will be requested when the pull request is marked ready for review mikeharder is a code owner

@raych1 raych1 Awaiting requested review from raych1 raych1 will be requested when the pull request is marked ready for review raych1 is a code owner

@maririos maririos Awaiting requested review from maririos maririos will be requested when the pull request is marked ready for review maririos is a code owner

@NonStatic2014 NonStatic2014 Awaiting requested review from NonStatic2014 NonStatic2014 will be requested when the pull request is marked ready for review NonStatic2014 is a code owner

@chen-karen chen-karen Awaiting requested review from chen-karen chen-karen will be requested when the pull request is marked ready for review chen-karen is a code owner

@heaths heaths Awaiting requested review from heaths heaths will be requested when the pull request is marked ready for review heaths is a code owner

@dsouzaarun dsouzaarun Awaiting requested review from dsouzaarun dsouzaarun will be requested when the pull request is marked ready for review dsouzaarun is a code owner

@damodaravadhani damodaravadhani Awaiting requested review from damodaravadhani damodaravadhani will be requested when the pull request is marked ready for review damodaravadhani is a code owner

@Kishp01 Kishp01 Awaiting requested review from Kishp01 Kishp01 will be requested when the pull request is marked ready for review Kishp01 is a code owner

@shankarsama shankarsama Awaiting requested review from shankarsama shankarsama will be requested when the pull request is marked ready for review shankarsama is a code owner

@rajeshka rajeshka Awaiting requested review from rajeshka rajeshka will be requested when the pull request is marked ready for review rajeshka is a code owner

@rkuthala rkuthala Awaiting requested review from rkuthala rkuthala will be requested when the pull request is marked ready for review rkuthala is a code owner

@MattGal MattGal Awaiting requested review from MattGal MattGal will be requested when the pull request is marked ready for review MattGal is a code owner

@tundwed tundwed Awaiting requested review from tundwed tundwed will be requested when the pull request is marked ready for review tundwed is a code owner

@AnamikaNupur AnamikaNupur Awaiting requested review from AnamikaNupur AnamikaNupur will be requested when the pull request is marked ready for review AnamikaNupur is a code owner

@yunheMsft yunheMsft Awaiting requested review from yunheMsft yunheMsft will be requested when the pull request is marked ready for review yunheMsft is a code owner

@jessicl-ms jessicl-ms Awaiting requested review from jessicl-ms jessicl-ms will be requested when the pull request is marked ready for review jessicl-ms is a code owner

@rrahulms rrahulms Awaiting requested review from rrahulms rrahulms will be requested when the pull request is marked ready for review rrahulms is a code owner

@ChenglongLiu ChenglongLiu Awaiting requested review from ChenglongLiu ChenglongLiu will be requested when the pull request is marked ready for review ChenglongLiu is a code owner

@Ptnan7 Ptnan7 Awaiting requested review from Ptnan7 Ptnan7 will be requested when the pull request is marked ready for review Ptnan7 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

data-plane resource-manager TypeSpec Authored with TypeSpec

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@v-jiaodi